css: generic .hidden class which can be overruled with .show class

Sometimes more convenient and efficient than plain jQuery using .show() and
.hide() and filtering on :visible.

This should be bootstrap compatible.

7834f845505a already depends on this :-(

pullrequests: show tags in lists of included and available changesets

Further improvement: Also show bookmarks and other names (preferably by using
some helper function/template instead of duplicating code). It would perhaps
also be better to avoid using floating.

pullrequests: restore display of "Current revision - no change" at the bottom of the list of available updates

Helps the user to understand that something can be selected.

design: make top-right profile button into an actual link

If a user is logged in, make the avatar, username and notification count into a
link to "My Notifications".

admin: remove check for empty Ui table

The table is populated on database creation, and assumed to be populated
so many places in the code, we're unlikely to even reach this point if
it's empty. (E.g. web.push_ssl must be defined to push/pull/fetch both
Mercurial and Git repositories.)

db: fix Ui.get_by_key to also filter on section

Key alone is not enough to identify a Ui row.

db: remove superfluous Ui table session adds

Only newly created objects (and objects explicitly expunged) need to be
added to the SQLAlchemy session; any object returned from a database
query is already in the session.

comments: limit comment deletion to a 5 minutes grace period

It is really a bad idea to delete a comment after the content and references to
it has been sent in mails.

Ultimately, comments should be editable and versioned - "delete" should then
just hide the comment.

Note: this is just done at the UI level - not verified on the server

pullrequests: make it possible to delete pull requests instead of commenting

Deleting a pull request might however be a bad idea - the reviews on the PR
will be lost.

comments: drop delayed activation of new comments

It is unclear what it fixed and we have tested this and haven't heard any complaints.

comments: fix class of inline comments without context

Not really relevant yet(?) but needed for future annotate support.

comments: extract common comment creation functionality for changesets and pullrequests

So far not big but it will grow later ...

comments: avoid js string formatting of html template from DOM - avoid insecure naming

Multiple inline comment forms were only distinguished by the line number - not
by the filename.

Instead, just keep it simple and avoid trying to assign "globally" unique names
and use jQuery instead.

comments: linkify revision hashes and issue tracker references

This was hard with RST markup - much easier to do reasonably safely in plain text.

comments: change comment formatting to plain text instead of rst

There might be value in enabling rich markup (especially if it is markdown
instead of rst) ... or it might be a waste of time. We might revisit that
later.

But either way: Changing to plain text makes it more feasible to do markup of
hashes and issues - for now that is more important than rtf.

helpers: introduce render_w_mentions

Eventually this function should support and auto detect multiple formats and is
thus not named for a specific format. But for now it is plain text only.

This kind of markup can quite easily and safely support additional magic
markup. It is much harder to do that on top of a richer markup format; it
must essentially be done in a single pass, with both all the various regexps
and the rst formatting done in a single pass.

auth: Fix bug where usernames are not consistently capitalized when using crowd login

If you try to log in to Kallithea via the Crowd auth module then the
capitalization of your username in Kallithea changes on every login based on
how you capitalized it in the login form.

E.g. Log in with "TestDude", username is entered as "TestDude" then log in
again, but this time as "tesTduDe", and your username gets changed to
"tesTduDe". etc.

Fix for this is to use the 'name' field returned from Crowd when saving the
username. This way the username is always capitalized identically to the record
in Crowd.

auth: Fix tomcat throwing '505 HTTP Version Not Supported' when trying to log in to Atlassian Crowd with usernames that contain spaces

If you try to log in to Kallithea via the Crowd auth module, and the username
contains a space, it fails. Tomcat on the Crowd server gives error '505 HTTP
Version Not Supported'.

Further investigation showed that the username was not being quoted. E.g. for
the user 'test account', the REST URL should contain 'test%20account' but
actually was containing 'test account'. When Tomcat received this HTTP request
it interprets the word 'account' as the HTTP version because of the space. This
obviously isn't a valid HTTP version.

This bug is fixed by using urllib2.quote on the username to ensure that special
characters are correctly quoted. After making that change on my local install,
the user 'test account' was able to log in successfully.

i18n: updated translation for Japanese

Currently translated at 93.3% (1057 of 1132 strings)

i18n: updated translation for Japanese

Currently translated at 93.3% (1057 of 1132 strings)

i18n: updated translation for Czech

Currently translated at 3.3% (38 of 1132 strings)

i18n: updated translation for Japanese

Currently translated at 93.3% (1057 of 1132 strings)

diff: align diff layout; give changeset diffs links and give PR diffs more action icons

I'm not sure this is better but it uses existing parts consistently.

diffs: introduce 'show inline comments' control for pull-requests too

Make diff_block_simple control inline comments like diff_block does.

.show-inline-comments handling is moved to the generic diff handling js.

I am not sure this is useful when the whole diff is sent to the client side
anyway ... but for now, let's be consistent.

diff: make diff_block_simple (and thus pull request diffs) collapsable as changeset diffs are

I am not sure this is useful when the whole diff is sent to the client side
anyway ... but for now, let's be consistent.

js: move .diff-collapse-button handling from the global base.js to the special diff js

Move it where it belongs and avoid adding more stuff to the global js later.

diff: move looping over files into diff_block_simple

Make it slightly more like regular diff_block and make the next changes
possible.

diff: fix display of images for deleted files

In preperation of refactoring diff handling, this change fixes
the handling of picture showing when a file gets deleted.

lib: drop fuzzy matching on full user names in user_or_none

The fallback of checking for matching user names is expensive, untested,
fragile, and almost useless.

db: make sure all (non-primary) columns have nullable set explicitly

The default of nullable=True is rarely good for us so nullable should always be
specified unless there is a reason to allow nullable ... and if the default is
fine, xplicit is better than implicit.

The declared nulliness of some fields are changed where it seems like code
already enforced it.

Some fields are marked as FIXME when they need (trivial?) data conversion to
convert NULLs to default values.

db: stop messing with convert_unicode in .ini and db scheme

convert_unicode=False is the default for String fields ... except when the .ini file contains sets it to True.

String fields are however no longer used for unicode and we can drop convert_unicode everywhere.

See
http://docs.sqlalchemy.org/en/latest/core/type_basics.html#sqlalchemy.types.String.params.convert_unicode
for the advice of never setting convert_unicode.

db: change unicode fields to have Unicode type instead of String

Drop convert_unicode for Unicode fields where it doesn't apply; these fields
always use unicode in the database and returns unicode.

See
http://docs.sqlalchemy.org/en/latest/core/type_basics.html#sqlalchemy.types.String.params.convert_unicode
for the advice of using Unicode for unicode fields.

tests: more consistently use unicode where unicode is expected

Nothing but extra u annotation to turn str constants into unicode.

This has been verified by hacking sqlalchemy to fail if wrong string types are passed.

tests: cleanup of unicode in test_create_non_ascii repository test

Repository names are generally conceptually unicode. Prepare for future changes
by explicitly encoding repo_name as utf8 before appending a utf8 string.

Drop test_create_non_ascii - test_delete_non_ascii contains exactly the same
test.

tests: always convert unicode paths to str before passing to vcs layer

Repo names are generally unicode. Don't rely on implicit conversion.

auth: get username as str when container auth gets username from user object

Avoid stray unicode username.

db: avoid specifying uniqueness constraints twice

Having both UniqueConstraint for a column on a table and unique=True on the
same column is both wrong, redundant, deprecated and cause warnings.

celery: stop using deprecated celery.decorators

We don't use the old magic keyword arguments and can just use celery.task
instead - see
http://docs.celeryproject.org/en/latest/history/changelog-2.2.html#version-2-2-0

db: introduce _table_args_default_dict with dict values for __table_args__

DRY.

ini: specify utf8 for sample MySQL connection strings

By default, the MySQL stack will store unicode as UTF-8 encoded data in string
fields, thus without using any unicode capabilities in the database.

As described in
http://docs.sqlalchemy.org/en/latest/dialects/mysql.html#mysql-unicode , set
charset=utf8 to actually put unicode in the database.

Existing databases that already store utf8 in the database should keep using
the old url.

This will only support 16 bit code points, but utf8mb4 will double the key size
and make them too big for MySQL.

middleware: decode the repo_name received from http header to unicode

The middlewares seemed to make the incorrect assumption that the headers
contained unicode. Or to put it differently: They relied on the Python default
encoding to be able to convert to unicode instead of using safe_unicode. It
would thus fail if running with LANG=C.

Instead, utilize that the header actually contains str_repo_name and explicitly
decode that to unicode.

db: fix unknown exception type in commit error handling

efce61aac33d was a blind fix. It failed because `from sqlalchemy import *`
doesn't import exc and the new except clause would thus fail. It also failed
because the session has to be rolled back after a commit failure.

Now, rework it to fix these issues.

Note that we are able to detect whether the commit failed for valid reasons ...
but we can't use that information to much ...

git: fix parsing of git mode change + rename diffs

Assume mode lines come first, like for hg diffs.

indexer: skip documents that can't be retrieved - probably because encoding issues (Issue #175)

This doesn't fix the encoding issue but it makes it less fatal.

auth: fail pam and internal authentication attempts if no username is provided (Issue #180)

When the Mercurial client communicates with a server over HTTP, it will always
first try to perform operations unauthenticated before providing credentials.
Authentication attempts without credentials is usually pointless and will just
slow operations down.

Some authentication plugins (such as LDAP) already skipped these
unauthenticated requests. Now, do the same for other authentication plugions.

Other authentication plugins also skip if no password is provided ... but that
doesn't seem necessary.

diff: get collapse target via .attr instead of .prop

Commit 3f017db297c4 was not fully tested and broke collapse/expand of diffs on
changesets. $button is not a link with a target and the target can thus not be
retrieved with .prop('target'); $button is just a span that happens to have a
custom attribute with the name 'target'.

We thus revert back to the old way of retrieving it with .attr('target'). (It
would perhaps be even better to use data attributes and name it data-target and
use .data('target') ...)

cleanup: introduce scripts/logformat.py for cleanup of string formatting of logging statements

Script used for cleanup in 0210d0b769d4 to replace logging with % formatting
with unformatted parameters.

auth: let login helper function return exception to raise instead of raising it self

Make the execution flow more obvious by raising the exception where it matters.

Avoid redundant and potentially misleading return statement that tried to make
it clear that execution wouldn't continue after the function call.

auth: only local passwords can be reset

Do for password reset what de9a3152c206 did for password change.

repo-scan: print status to stdout instead of logging it

Don't mute command line output just because the .ini file not is verbose.

setup: support the Mercurial 3.6 series

No significant API changes and testing doesn't show any problems.

This upgrade enables use of bundle2 with generaldelta.

select2: make "Switch To" switch to changelog view everywhere, except in Files context

When already in changelog context, it will apply the change to the existing
branch_filter.

menu: Added select2 box for "Switch To", work towards having general revision context

Major changes by Takumi IINO <trot.thunder@gmail.com>.

select2: show prefix matches first in #repo-switcher

Do as 4f4d2e899a02 introduced for the PR/changelog branch select2 boxes.

select2: be case insensitive when putting prefix matches first in result lists

The filtering is case insensitive.

cleanup: fix 'try ... except ...' formatting missed in d69aa464f373

Examples spotted by Jiří Suchan <yed@vanyli.net>.