pull requests: call it 'owner' instead of 'author'

Prepare for making it possible to transfer ownership of PRs.

follow: various minor cleanup

A debug session gave no other result than this +0.1 cleanup ...

docs: consistent spacing around headings

Start out with 2 empty lines before/after for top level, decrease for deeper
levels.

auth: avoid random auth_internal failures - add explicit import of auth_internal to user admin

auth_internal would often have been loaded by the custom auth module loader and
available as auth_modules.auth_internal ... but sometimes it wasn't and
navigating to Add User would fail with:

File '.../kallithea/controllers/admin/users.py', line 155 in new
c.default_extern_type = auth_modules.auth_internal.KallitheaAuthPlugin.name
AttributeError: 'module' object has no attribute 'auth_internal'

users: fix missing c.readonly in UsersController.update error rendering

The c.readonly attribute, while correctly set in UsersControllers.edit,
was not assigned in UsersControllers.update, causing a template error
if the form validation failed. This commit unifies template rendering
in separate method to fix this and avoid future problems.

i18n: updated translation for Chinese (Taiwan)

Currently translated at 15.3% (171 of 1116 strings)

docs: update menu navigation notation to use *Menu > Menu Item*

Follow Apple's notation for 'Menus' from
http://help.apple.com/asg/mac/2013/#apsg1f285825 .

spelling: fix inappropriate use of title case

These are not titles or labels, and should not be title cased.

pullrequests: remove reviewer list during PR creation

There is not much use for it before the actual diff is shown ... and removing
it also removes a bit of duplicated code that otherwise should be maintained in
two places.

docs: try to improve the web server overview page

Say more about the role of paster and reverse proxies and do not give any hints
that the combination should be a magic silver bullet.

vcs: invalidate repo caches _after_ a push finishes

Caches were invalidated right after creating the result iterator, before
actually applying the change. Caches would thus be refreshed too early and soon
be outdated.

This bug was especially seen causing errors with missing revisions when
creating PRs right after pushing.

docs: cleanup of casing, markup and spacing of headings

Mostly stuff found and fixed by Søren, extracted here to separate things.

Other uses of title casing might be debatable, but here it was just a few
documentation headings that clearly were inconsistent with the majority.

spelling: use "email" consistently

The common English spelling is "email", not "e-mail" (and was indeed
also the most common, but not only, variant in the Kallithea UI).

http://grammarist.com/style/e-mail-email/

tests: add regex version of checkSessionFlash

This is needed to match more complex messages.

spelling: unify messages for repository locking

Normalize phrasing and capitalization of repository locking messages.
This also avoids the piecing together of sentence fragments in a way
that can cause i18n headaches.

misc: remove alt-text from Gravatar images

The alternative text should convey the same information as the image,
something which the text "gravatar" does not. (In a context where the
gravatar is used on its own, the username could be a useful alt-text
- and title-text - but it's not apparent that this is ever the case.)

pullrequests: require extra confirmation before deleting a PR with comments

Make sure we don't lose any valueable data. A PR without comments doesn't have
much value.

docs: improve documentation of beaker session configuration

beaker.session.auto is dropped; it defaults to false and there is no reason to
ever set it true for Kallithea.

beaker.session.cookie_path and secure are dropped; like cookie_domain, they
should automatically be set to the right value.
* * *
beaker.session.cookie_expires MUST have the default value of True to provide the default value of 'browser session lifetime' when not enabling 'remember' in the login box. The cookie life is hardcoded to 365 days when remember is selected.

cleanup: fix some risky variable redefinitions

Found with pyflakes.

cleanup: remove unused imports

Found with pyflakes.

db: better handling of decoding of changeset_cache values from the database

Do some validation of the data to prevent that incorrect data cause weird
failures when they are used later on.

comments: move spacing around status radio buttons to css

Convenient when we add more radio buttons.

comments: fix warning when unloading page with unsaved comments

e87baa8f1c5b broke the existing check. Instead, only set the
comment-inline-form class when it actually is an inline form and use that class
for finding comments.

comments: browser display of context around url #targets should only be used for diff comments

24d01c64c5f3 had the unintended side-effect of not only highlighting the linked
line in file view but also the spacing above it. For now, instead of changing
the markup, restrict the fancy #target offsets to comments.

tox.ini: declare 1.8 as minimum tox version

Older tox versions will fail with
tox.ConfigError: ConfigError: substitution key '26,27' not found

Older tox versions will apparently not understand minversion anyway, but
at least it states the intent ...

js: refactor AutoComplete functions to pass jQuery results around until DOM elements are passed to YUI

A small step forward that enables other refactorings.

pullrequests: avoid unnecessary scroll-bar on short lists of available updates with Chrome

The surrounding div will apparently take size after the content but miss that
there also is 1 pixel border ... and when drawing it realizes that there isn't
enough space and it adds scroll bars anyway.

Work around that by giving the surrounding box 1 pixel padding.

graphs: set initial canvas size to 0

The canvas will be set to the right size when the page has loaded. Until the
page has been loaded, Chrome has been seen to set the canvas to be so wide that
it would cover other visible links, thus preventing navigating away from the
page before it has been fully loaded.

This will make sure the canvas never takes up more space than intended.

comments: bind comment-bubble click handler to table and use sub selector

Avoid jQuery looping over all lines and binding comment-bubble click handler to
every line on page load.

Avoids 'Maximum call stack size exceeded' when loading a huge diff in Chrome.

helpers: drop incorrect % escaping in fancy_file_stats

% should not be escaped when not doing % formatting.

setup: reintroduce nosetests support that was removed in Pylons after 1.0.0

Use workaround from https://github.com/Pylons/pylons/issues/13 .

setup: drop unused simplejson dependency

c796b6bdd532 removed the use of it but didn't drop the dependency.

cleanup: make module self-naming consistent

The self naming is quite pointless ... but at least make it right.

cleanup: consistently use 'except ... as ...:'

Use the Python 2.6+ syntax instead of the old confusing 'except ..., ...'
syntax.

kallithea_config: properly handle Unicode characters in .ini template

template.ini.mako declares itself as UTF-8, but actually putting unicode in the
file made kallithea_config.py fail with UnicodeEncodeError.

Fix by making sure the template is read as UTF-8.

vcs: remove pointless stream reopening / seeking in hg fill_archive

test_archival started failing after 8e72e78a7d9e refactored the controller to
pass a stream created by fdopen.

The failure was in code that doesn't make any difference anyway - just kill it.

i18n: updated translation for Belarusian

Currently translated at 86.5% (965 of 1115 strings)

i18n: updated translation for German

Currently translated at 65.6% (733 of 1116 strings)

i18n: updated translation for French

Currently translated at 65.5% (732 of 1116 strings)

e-mail: add documentation about configuration settings

Document e-mail related configuration settings in the documentation
(overview) and the .ini file itself (technical details and example
settings).

e-mail: add some default values and some examples to .ini file as comments

This includes a replacement of @localhost examples to @example.com, to
indicate that real addresses should normally be used.

comments: when linking to specific comments, make the browser show a bit of the context of the comment

Make the link targets have an invisible pre: that goes 100px above the target.

comments: previous/next links should only be to first comment for a given line

Before, each comment had its own link to previous/next comment - also if it was
right before/after in the same thread. Comments right before/after in the same
thread are however easy to navigate to with scrolling or arrow keys or
pageup/down. Navigating to the next thread could take a lot of clicks to cycle
through every single comment ever made.

Instead, just show the link at the top of each thread and let the links
navigate between threads.

This also make long threads use less vertical space.

One downside of this change is that it for long threads takes a bit more work
to get from the last comment in a thread to the next thread.

comments: rework/rewrite javascript for inline comment handling

There shouldn't be any functional changes here, but the focus has been on doing
the right thing instead of looking at how it was before.

Incremental cleanup did not seem feasible. I think this is more readable and
maintainable than before ... at least for me.

Existing snippets has been reused when reimplementing. The new implementation
focus on being as simple as possible and well-structured. jQuery and data
attributes are used instead of custom implementations. Some existing functions
have been modified or renamed, others have been removed when they no longer
were needed.

mercurial: support Mercurial 3.5

test_archive failed without the hgcompat workaround.

pylons: support Pylons 1.0.2

Pylons 1.0.2 requires webob>=1.1.1 and Pylons 1.0.0 seemed to have problems
with later versions so stick the minimum version for now.

e-mail: properly handle no recipients when there is no email_to set

When the configuration file does not contain a value for email_to, and no
recipients are specified in a call to send_email, recipients would be set to
[None, admins]
which causes an error when logging this list as ' '.join(recipients).

e-mail: revive dead code that checks for unspecified recipients

Commit 609e06b6c52f6a8ea9581372805c4bbb60db81a1 introduced dead code:
in the beginning of send_email an assert verifies that recipients is of type
'list', so checking it for None later is useless and that branch can never
be reached.

Instead of removing the dead code, revive it and add a test case.

e-mail: add trivial test case

Add a first trivial e-mail test, new tests to be added in subsequent
commits.

privacy: don't tell users what is the reason for a failed login

Makes it harder for strangers to probe the instance for presence of
certain users. This can make it harder to break in, as it is now
harder to tell is a username or a password are wrong, so bruteforcing
should probably take a bit longer if you don't know what exactly are
you doing.

auth: make sure that users only can manage their own primary data if self registration is enabled

With the UI showing exactly which fields are used and which are ignored, there
is no reason to show the 'External Source of Record' warning.

css: match on the readonly-ness instead of explicitly setting 'disabled' class on input elements

Note: the 'disabled' class is 'readonly' and different from the html/css
'disabled' concept.

users: cleanup of handling of the extern_type and extern_name fields in html forms

Note: There is controller support for editing extern_type and extern_name but no UI.