style: drop 'checkboxes' class inside 'form-group'

Temporarily, just apply styling to div inside form-group. Also, 'radios' is gone.

Based on work by Dominik Ruf.

style: drop 'input' class inside 'form-group'

As long as we use the old styling, just apply styling to div inside form-group.

Based on work by Dominik Ruf.

style: introduce radio-inline / checkbox-inline for status votes - preparing for Bootstrap but so far not used

Based on work by Dominik Ruf.

style: introduce well markup - preparing for Bootstrap but so far not used

Based on work by Dominik Ruf.

style: drop dead 'field' class references

The last references to the class does not match anything essential, and all
css styles can thus also be removed.

Based on work by Dominik Ruf.

style: temporary style tweaks before Bootstrap

Some input fields were truncated - especially if 100% width.

style: drop unused 'focus' class - controls should be 'form-control' instead

Based on work by Dominik Ruf.

templates: use Bootstrap compatible 'form-control' name instead of 'medium' & co

In Bootstrap, form controls tend to be 100%.

tests: use test_context for tests needing internationalization

Instead of relying on the top-level handling of the translator, use the
newly introduced test_context.

tests: introduce test_context to handle internationalization

As preparation to the migration to Turbogears2, introduce a test_context
context manager to wrap certain tests. The context manager provides a
translator for tests that need it. This translator was previously provided
globally to all tests via the TestController.

When swapping Pylons with Turbogears2, the new file
kallithea/tests/test_context.py can be removed, and the test_context from
tg2/tg/util/webtest.py should be used.

tests: remove unused code from conftest.py

conftest.py does not contain an import of pylons (only of pylons.test) so
usage of e.g. pylons.config can never work, so it cannot be used.
Since the tests run fine regardless, we can get rid of this code.

docs: remove some references to Pylons

These references are either not used, or do not provide value.
The Windows installation and email pages still references documents from the
Pylons website -- alternative pages from Turbogears2 need to be found.

error: remove unused Pylons-specific img/style methods

The img and style methods in the error controller are standard Pylons
boilerplate. They are used from the Pylons default error document template.
The purpose of these methods is to serve images and stylesheets from the
Pylons module, rather than having to copy these files into a particular
application installation.

Since Kallithea uses a custom error template with our own styles and images,
these methods are not actually used.

pullrequests: fix 'upgrade' from revision to branch when creating PR

This will do that the default title for the PR created from a non-head revision
will contain a short hash instead a long.

org_ref_type was set to 'branch' while org_ref_name remained the full hash.
h.short_ref would thus not truncate. Instead, we keep the org_ref_type as 'rev'
while storing the branch name in the database.

auth: prevent LDAP query language injection of usernames

This could cause odd LDAP queries that could fail but couldn't give access
without a valid user query and credentials. It thus had no security
implications.

auth: make ldap OPT_X_TLS_CACERTDIR configurable

A location was hardcoded. The location was wrong for many systems and prevented
actual TLS from working. Also, it should not be necessary with modern Pythons.

For some reason, instead of removing it, we now decide to expose it to the
user. Choice FTW!

repo_group: more flexible handling of trailing '/' in repository group names

Don't fail on /_admin/repo_groups/REPO_GROUP_NAME/ .

repo_groups: set c.active when displaying repo creation form errors through repo_group_edit.html

Writing failing tests revealed a crash.

utils: fix broken URL in jsonify warning

Also add a note summarizing the linked concerns.

tests: fix incorrect API key tests

These parameterized tests were supposed to (among other things) test
what happens when the "api_key" query string parameter is not present.
Instead, they literally tested "api_key=None".

auth: remove KallitheaCrypto pseudo-class

Every caller except one already used the module-level wrapper functions.

pullrequests: refactor PullRequestModel().create

The database lookups of the user and repositories are moved outside,
into the callers, which have already looked up the relevant objects,
thus saving two database lookups when creating a PR.

db: it should be "PullRequestReviewer" (singular)

sed -i 's/\bPullRequestReviewers\b/PullRequestReviewer/g' $(hg files)

Just as it's "User", "PullRequest", etc. It's not a collection.

db: rename Gist.gist_owner to Gist.owner_id

For consistency with the existing "owner" relationship.

db: rename ChangesetStatus.changeset_comment_id to comment_id

This ensures consistency with the existing "comment" relationship, as
well as the foreign key (ChangesetComment.comment_id).

db: rename UserFollowing.follows_repo_id to follows_repository_id

Since the relationship is 'follows_repository', rename the column to be
'follows_repository_id', not 'follows_repo_id'. This also makes the
Python column name match the actual database column name.

(The inconsistency dates back to early RhodeCode days.)

db: rename RepoGroup.group_parent_id to parent_group_id

Also for consistency with the existing parent_group relationship.

db: clean up SQLAlchemy session flushes

Many calls to Session().flush() were completely superfluous and have
been removed. (See also the note on "flush" in the contributor docs.)
For the remaining calls, a comment has been added to explain why it's
necessary.

docs: separate coding/contribution guidelines

Try to separate "process" guidelines from "content" guidelines.
(Just moving stuff around here, not changing the actual guidelines.)

login: clarify "Remember be" checkbox - it controls if session should expire with browser session or at timeout

Hint that it is related to cookie expires attribute.

style: put all datatable widgets on one line above the table

This makes tables look less messy - especially on the repogroups page where
there are 2 datatables.

We put all the info above the template so it is visible and stays in the same
place, no matter how many entries are shown or if filtering change the number.

TODO: We should probably get a wrapper around datatable instead of repeating
this so many times ...

templates: fix dropdown functionality of current menu item

After 3e46e6b6a27a, the 'current' menu would have two class attributes and it
would not work as a dropdown. For example, it was not possible to navigate from
Admin>Users to Admin>User Groups.

Instead, get rid of the is_current "helper" and just handle classes explicitly.
That might be slightly more verbose but is also more explicit ... and it works.

style: use Bootstrap compatible markup for alert

Based on work by Dominik Ruf.

style: use span for notifications

Based on Bootstrap work by Dominik Ruf.

style: use span for reviewers instead of div

Based on Bootstrap work by Dominik Ruf.

style: use Bootstrap compatible "text-muted" class

Based on work by Dominik Ruf.

style: introduce "clearfix" class where the Bootstrap migration will need it

Based on work by Dominik Ruf.

style: use Bootstrap compatible data-toggle="tooltip" markup

Based on work by Dominik Ruf and Andrew Shadura.

templates: use bootstrap pagination

The origiinal patch has been modified by Mads Kiilerich.

template: remove obsolete filter textbox and user_group_count

I used grep to find any reference to user_group_count but found none. So there
seems to be no code that actually sets this count. So I removed it.
And since the table is a datatable the filter is redundant anyway.

style: fix structure of my account profile

The avatar was outside the usual wrapping structure.

style: quite-but-not-entirely trivial cleanup of the "search" UI

Providing a cleaner baseline for Bootstrap.

style: quite-but-not-entirely trivial cleanup of "settings, visual"

Providing a cleaner baseline for Bootstrap.

style: replace some disabled btn with Bootstrap compatible label markup

Based on work by Dominik Ruf.

style: refactor form label styling to prepare for Bootstrap and get rid of wrapping with 'label' class

Based on work by Dominik Ruf.

style: put all admin form buttons in a form-group, as our future Bootstrap likes it

Based on work by Dominik Ruf.

style: replace action_button with Bootstrap compatible btn class names

Based on work by Dominik Ruf.

style: use span for tag/bookmark tags ... and make it inline-block to avoid wrapping

Based on work by Dominik Ruf.

style: use Bootstrap compatible btn-danger instead of red ... and similar for other button types

Based on work by Dominik Ruf.

style: adjust button sizes to be more like Bootstrap and change some btn-sm to btn-xs

Based on work by Dominik Ruf.

style: don't use div.action_button for PR reviewers

This is an odd button. The remaining action buttons are more regular.

Based on work by Dominik Ruf.

style: in preparation for Bootstrap, refactor to use Bootstrap compatible form class names

Based on work by Dominik Ruf.

Mostly:

sed -i \
-e 's,<table>,<table class="table">,g' \
-e 's,<div class="fields">,<div class="form-horizontal">,g' \
-e 's,<div class="field">,<div class="form-group">,g' \
-e 's,<label for="\([^"]*\)">,<label class="control-label" for="\1">,g' \
`hg mani`

cat kallithea/public/css/style.css | \
sed -e '/\.fields\>/{p;s/\.fields/.form-horizontal/g}' | \
sed -e '/\.fields\>/s/ {$/,/g' | \
sed -e '/\.field\>/{p;s/\.field\>/.form-group/g}' | \
sed -e '/\.field\>/s/ {$/,/g' | \
sed -e '/\.fields\>.*\.form-group\>/d' | \
sed -e '/\.form-horizontal\>.*\.field\>/d ' | \
cat - > kallithea/public/css/style.css.tmp
mv kallithea/public/css/style.css.tmp kallithea/public/css/style.css

email: add X-Kallithea-Notification-Type header

To simplify email filtering, add a header indicating the type of email being
sent. The 'type_' value corresponds to one of the types defined in class
Notification in kallithea/model/db.py, e.g. 'cs_comment', 'pull_request',
'pull_request_comment', ...

lib: move get_custom_lexer from utils to pygmentsutils

get_custom_lexer is the only dependency from helpers to utils.
In attempting to get a clearer dependency tree, we can move out
get_custom_lexer to a different place so that helpers does not depend on
utils.

It so happens that there already is a pygmentsutils.py file in lib, which is
a very good fit, since the lexers used in Kallithea are effectively provided
by pygments.

helpers: remove direct global imports from model

To avoid circular imports, we need to determine some 'rules'.
Helpers have minimal dependencies to model. Most of the model imports that
are currently global are only used in a few methods. Therefore, it makes
sense to make these imports local to the method, so they won't 'count' for
circular imports at module level.

tests: fix pull request tests - review_members is not a string but a list of integers (as strings)

Also sneaking in a bit of response status cleanup ...

style: in preparation for bootstrap, add bootstrap compatible field classes

This is a subset of a bigger changeset. The subset was extracted by Mads Kiilerich, mostly by:

sed -i \
-e 's,<div class="fields">,<div class="fields form-horizontal">,g' \
-e 's,<div class="field">,<div class="field form-group">,g' \
-e 's,<label for="\([^"]*\)"">,<label for="\1" class="control-label">,g' \
`hg mani`

style: in preparation for bootstrap, replace kallithea title class with bootstrap compatible panel-heading

This is a subset of a bigger changeset. The subset was extracted by Mads Kiilerich, mostly by:

sed -i 's,<div class="title\>,<div class="panel-heading,g' `hg mani`
sed -i 's,\<div\.title\>,div.panel-heading,g' kallithea/public/css/style.css

style: in preparation for bootstrap, replace kallithea box with bootstrap compatible panel

This is a subset of a bigger changeset. The subset was extracted by Mads Kiilerich, mostly by:

sed -i \
-e 's,<div\(.*\) class="box",<div\1 class="panel panel-primary",g' \
`hg mani`

style: in preparation for bootstrap, use bootstrap compatible button class names

Give all buttons a styling (default, success, danger, warning) and rename the sizes to sm and xs.

This is a subset of a bigger changeset. The subset was extracted by Mads Kiilerich, mostly by:

sed -i \
-e 's,btn btn-small,btn btn-default btn-sm,g' \
-e 's,btn btn-mini,btn btn-default btn-xs,g' \
-e 's,btn-default btn-\(xs\|sm\) btn-\(success\|danger\|warning\),btn-\2 btn-\1,g' \
-e 's,class_="btn",class_="btn btn-default",g' \
`hg mani`

config: remove unused symbols DATE_FORMAT / DATETIME_FORMAT

These were previously imported by helpers.py, but without actual usage
anywhere.

helpers: remove unused imports

helpers.py imported tons of unused names.
Most of these are assumed to be due to historical changes without cleanup.
Several webhelpers names were imported as a group, but this is not deemed
useful.

helpers: remove unused get_error / _GetError

This method/class was introduced in the very first commit of this
repository, but is no longer used.

helpers: remove unused wrapper method is_following_repo

kallithea.lib.helpers is a plain wrapper around ScmModel.is_following_repo
and is used nowhere.

helpers: move Page/RepoPage to a separate file page.py

The Page and RepoPage classes are not used from templates and thus do not
belong in helpers.
They could have been put in utils.py, but because they are completely
standalone we can easily split them to a separate file.