rcextensions: cleanup of code and documentation

More cleanup is needed - this is just to clarify what it currently does.

permissions: by default, don't show entities with no access

There might be a lot of entities the user/group don't have access and it is
much more important to be able to see at a glance what the user/group has to
access to than what it doesn't have access to.

templates: drop autocomplete="off" - it is ignored by browsers

This is annoying for admin when setting passwor for other users - we will have
to do that in some other way.

changelog_summary: show changeset status label rather than raw status

Instead of showing the changeset status as e.g. under_review, use 'Under
Review', like all other similar code.

changelog: use status label directly from c.statuses.get() output

In the changelog template, c.statuses.get() returns a list:
[ str(status), status_lbl, pr_id, pr_repo ]

So to obtain the status label, one can directly use the second element,
rather than using a helper function on the first.

comments: avoid storing 'No comments' text when changing status

When a general comment (with or without status change) is added to a
changeset or pull request, and no text was added, Kallithea automatically
used 'No comments' as text. The stub text is added to the database as if it has
been entered by the user and it can thus not easily be identified as an
automatic comment.

This commit makes following changes:
- allow adding an empty comment to the database when there is a status
change. An empty comment without status change is ignored.
- do not add a stub text to the database, but generate it on demand
- the stub text is shown in italic font to differentiate it from user-entered
text

Currently there is a large amount of duplication between
controllers/changeset.py and controllers/pullrequests.py, which is to be
cleaned up in a later commit.

tests: update for git sometimes emitting 'Cloning into' on stderr

Tests failed with Git 2.1.0 .

tests: rename test_vcs_operations.py to avoid automatic pick-up

This is a special test that requires special setup and must be run manually.

Nose already skips the test because it is executable.

tests: restore pytest norecursedirs default patterns

This replaces d741b99effdf by adressing the root cause: 5c8c77b7ca56 removed
the default exclude of .* (and thus also .eggs/ used by latest setuptools) and
*.egg (used by older setuptools).

tests: Move pytest config (norecursedirs) from tox.ini to setup.cfg

Avoid (conceptual) dependency on the tox meta test runner configuration.

tox.ini: Add .eggs to norecursedirs

This prevents py.test from trying to run tests in the .eggs directory, which
setuptools can create.

tests: avoid executing tests in base classes

Fixes lots of failures with pytest by making sure base test classes don't
inherit from unittest.TestCase or by prefacing name with an underscore so tests
don't get executed by pytest.

tests: add pytest section and put tox and tests/scripts to norecursedirs

kallithea/tests/scripts are non-integrated messy tests
that cant be part of a testsuite as is

pullrequest overview: fix 'my pullrequests' overview

Commit bd4f453a0055 fixed the pager links on pullrequest overviews, but
broke the 'my pull requests' page due to insufficient testing and
incomplete Python understanding.

changeset status: fix common case where a reviewer did not yet review anything

When a reviewer did not yet make any review, its status for the changeset is
None, causing the code to crash. The unit tests also did not cover this case.

fonts: update symbol codes to be closer to real Unicode

Let's use character codes closer to what Unicode defines, so if the
custom font can't be used for some reason what user sees is still
more or less readable.

comments: display username and name instead of only username

The full name is more significant to many people than a username.

changeset status: set status to rejected if at least one reviewer rejected

Currently, a reject of a change by a reviewer does not affect the overall
status at all. A logical policy is to reject the change if at least one
reviewer rejects it.

Note: different repositories/organizations may require different policies
for the overall status. Currently, the policies for approve/reject are
fixed. A possible improvement is to provide several alternative
policies and allow selecting the policy per instance or per repo.

changeset_status: add unit tests for calculation of overall status

Add unit tests for the calculation of the review status of a changeset/pull
request. To allow this, some reorganization of the ChangesetStatusModel is
needed.

db: remove redundant Column namings

sed -i "s,^ \(.*\) = Column('\1'\, , \1 = Column(,g" kallithea/model/db.py

db: fix gist_owner database field name - it is user_id

Fix bug introduced in 3533ee5cbb62.

error: fix handling of errors without response

Broken by 6f9dae4d39d9.

tests: set app_globals and translater in conftest.py for py.test

Copy over code from the pylons nose plugin for setting app_globals and for
setting a translator object.

This allows more of the functional tests to pass; particularly the ones related
to i18n.

tests: Destroy user_user_group 'perms_group_1'

This doesn't seem to be a problem when running `nosetests`, but with `py.test` for some reason it becomes a problem:

$ py.test kallithea/tests/models/test_user_permissions_on_repo_groups.py kallithea/tests/models/test_user_group_permissions_on_repo_groups.py --maxfail=1 --tb=short
...
build/bdist.macosx-10.6-intel/egg/sqlalchemy/engine/default.py:331: in do_execute
cursor.execute(statement, parameters)
E IntegrityError: (IntegrityError) UNIQUE constraint failed: users_groups.users_group_name
u'INSERT INTO users_groups (users_group_name, user_group_description, users_group_active, users_group_inherit_default_permissions, user_id, created_on, group_data) VALUES (?, ?, ?, ?, ?, ?, ?)' ('perms_group_1', 'DESC', 1, 1, 2, '2015-04-08 17:38:03.457963', None)
...

tests: Eliminate use of nose.tools.with_setup - it is nose-specific

Instead, simply make `permissions_setup_func` set the baseline permissions.

tests: Make `parameterized` stuff work with both pytest and nose

- Use `nose.tools.nottest` if `nose` is available
- Use `pytest.mark.skipIf` if `pytest` is available
- Rename from `nose_parametrized` to `parameterized` since it's no longer
nose-specific

tox.ini: Set PYTHONHASHSEED = 0

because there is some non-deterministic stuff that can fail without this

i18n: updated translation for Hungarian

Currently translated at 1.0% (12 of 1116 strings)

setup: bump mercurial requirement to 2.9

Commit 1cd9bdf1362d started using iterbranches() method of branchmap

tests: Add conftest.py for pytest

This adds a conftest.py for pytest that initializes the Pylons app so that the
SQLAlchemy session is bound and such.

This is sort of the Python analogue for the nosetest plugin that Pylons
includes: https://github.com/Pylons/pylons/blob/master/pylons/test.py

tests: PEP8ify test_user_groups.py

This eliminates flake8 warnings:

kallithea/tests/models/test_user_groups.py:3:1: F403 'from kallithea.tests import *' used; unable to detect undefined names
kallithea/tests/models/test_user_groups.py:22:5: E303 too many blank lines (2)

tests: Remove imported_from_test function

AFAICT, this function is not used:

$ ag imported_from_test
kallithea/tests/nose_parametrized.py
144:def imported_from_test():

.hgignore: Add .eggs/ and tarballcache/

Setuptools >= 7.0 and .eggs is created and populated with eggs if setup.py has
setup_requires of packages that are not installed and setuptools has to
download them to satisfy the requirements. See
https://bitbucket.org/pypa/setuptools/pull-request/97/cache-eggs-required-for-building-in-eggs/diff#

tarballcache comes from test.ini : archive_cache_dir = %(here)s/tarballcache

auth: check CSRF protection token when authenticating

Use pylons secure_form to get CSRF protection on all authenticated POSTs. This
fixes CVE-2015-0276.

GETs should not have any side effects and do thus not need CSRF protection.

Reported by Paul van Empelen.

tests: provide _authentication_token when POSTing

So far not used, just preparing for the the time when the actual checking is
introduced ...

This change is very verbose. self.app.post should perhaps just at this value
automagically ...

javascript: provide secure_form compatible_authentication_token in all AJAX POSTs

_authentication_token is introduced as a global javascript variable. That seems
less ugly than passing it through as parameter everywhere ... and the token
really _is_ a global thing.

forms: use secure_form to add authentication token to all html forms

Towards CSRF protection ... but not yet checked

manifest: include (almost) all repo files in the release tar

Before running sdist, make sure it contains exactly the right files by running:
hg purge --all
python setup.py compile_catalog

i18n: don't include .mo files in the repo - build them on demand

(We do however keep the english .mo for now to preserve backwards
compatibility.)

i18n: drop redundant english translation

lang should thus be set empty instead of 'en', but we keep the en .mo around
to avoid upgrade issues.

i18n: remove translations that 5e7bdfbef29b made both fuzzy and invalid

Get rid of compile_catalog errors.

i18n: updated translation for Polish

Currently translated at 65.4% (730 of 1116 strings)

i18n: updated translation for Slovak

Currently translated at 4.5% (51 of 1116 strings)

i18n: updated translation for German

Currently translated at 42.7% (477 of 1116 strings)

i18n: updated translation for Russian

Currently translated at 77.5% (866 of 1116 strings)

summary: repeat repo type in front of clone URL

Repeatedly, users report cloning problems of the Kallithea sources on IRC,
caused by them assuming that it is a Git repository.

Try to solve this problem by repeating the repository tag, indicating 'hg'
or 'git' in front of the clone URL.

Additionally, decrease the font size of the URL a notch, and improve
alignment with the repotag by removing top/bottom padding.

To avoid duplication of the repotag logic, introduce a mako def for it.

docs: create separate 'Administrator guide'

The current 'Usage' section combines real usage information (intended for
repository owners) with information for administrators.
Instead, create a distinct 'administrator guide'.

docs/usage: move Mercurial subrepository info to VCS support page

This commit moves the information verbatim, text changes will be done in a
subsequent commit.

docs/usage: generalize 'git support' into 'version control systems support'

Rename and rework the 'git support' page such that it can hold information
about Mercurial as well.

docs/usage: fix section 'trending source files'

The source code reference for the 'trending source files' dictionary was no
longer correct, so update it.
Additionally, some small rewording.