font: fix missing icon-comment-color and icon-comment-alt

We replace the font with our icon-comment one since we can color this with css.

templates: changelog_summary: remove non-existing CSS class table_disp

The changelog_summary template references a non-existing CSS class
table_disp. Remove it.

my pullrequests: line up controller/template handling with repo pullrequests

Currently, the data for 'my pullrequests' is loaded dynamically through
ajax, unlike the way 'repository pullrequests' are loaded (statically).

As there is no good reason to have both treated differently, and as dynamic
loading of 'my pullrequests' is not really needed, rework the handling of
the 'my pullrequests' page with the 'repository pullrequests' page.

This includes lining up the 'show closed pull requests' checkbox/link.

This also fixes issue #102 ('my pull requests' when not logged in:
incorrect handling of login).

pullrequest overview: sanitize display style

Remove the unnecessarily large font size on the pullrequest overview to line
up with the styling of 'my pullrequests'.

Additionally, add some whitespace between the 'show closed PRs' link and the
actual list.

controllers: don't pass rendered templates in context variables

Some controllers used the followifng pattern:
- render a data template into a context variable
- for partial (ajax) requests, return the contents of this variable
- for full-page requests, render the full page, which expands the value of
the context variable

Instead, avoid context variables let the controller simply render the full or partial page, and let
the full page template include the partial page.

Remove this context variable for templating and use render exclusively.
From templates, use %include instead of context variables.

This in line with the suggestions in the Pylons documentation:
http://pylons-webframework.readthedocs.org/en/latest/helpers.html#partial-updates-with-ajax

templates: move site branding in page title to base template

Instead of repeating the same three lines in each and every template, move
it to the base template.

pullrequests on different repos: default to same destination/source branch

When a pull request is initiated between two different repositories, instead
of using the current tip as destination branch, use the same branch as on
the source repository.

tests: move helper commit_change from compare test to fixture

Move the generic helper function _commit_change() to the fixture class,
allowing reuse by other test classes.

repository summary: avoid table bleed on long commit messages

For commit messages with the first line being very long, the 'latest
changes' table on the repository overview page can 'bleed', so that the
commit number overlaps with the commit status.

Commit 15cb8156b10d732cf39b37a88c656894621c0f54 changed the initial truncate
on 50 characters to a chop at the first newline characters, causing this
issue to pop up more frequently.

Instead of using floating divs for the commit status and number of comments,
use dedicated table columns, as compact as possible.
Additionally, move these new columns to the very left of the table, instead
of cramming them in between the revision and commit message.

The comments-container class gets a new attribute 'white-space: nowrap' to
avoid the comment icon to wrap from the number of comments, when the table
does wrap on a small screen.
Note that the icon currently does not display as it should be renamed from
icon-comment-alt/colored to icon-comment. This will be fixed by Sean Farley.

changelog: fix display artifacts in expanded multi-line commit messages

When a multi-line commit message is expanded in a changelog, and the last line
of the commit message has some characters that go below the baseline, like an
underscore, g, j, y, ... the bottom part of these characters would not be
shown.

This is caused by the 'overflow: hidden' property set on the unexpanded
message. Reset that property by adding 'overflow: initial' on the expanded
class.

Additionally, slightly enlarge the margin of the expanded message box.

giticon.png: use repotag class to make an icon

A quick search revealed that some old css code was never used, so it was
removed.

hgicon.png: use repotag class to make an icon

The inline 'style' attribute was modified to remove the color but nothing else,
as was discussed with other Kallithea devs, since it makes more sense to leave
the spacing until another pass of css refactoring.

A quick search revealed that some old css code was never used, so it was
removed.

pullrequests: allow closing only by author and admin

A pullrequest should not be closable by any reviewer, especially not since
there is no reopening feature.

The check on change_status is no longer necessary, as the new permission
check is more restrictive.

repository 'latest changes': only show first line of commit message

Instead of truncating the commit message at a fixed number of characters,
behave like standard version control commands (e.g. hg log) and only show
the first line of the commit message in an overview.

pull requests commit overview: respect newlines and indentation (Issue #79)

Before this commit, commit messages in the pull request commit overview
would be handled like any other text in HTML, with newlines and multiple
whitespace being irrelevant.

Remove an overrule in the CSS so that the 'white-space' property remains at
'pre-wrap', causing newlines and indentation in commit messages are properly
respected in this overview. As a positive effect, only the first line of the
commit message is shown by default, just like in standard version control
commands like 'hg log'.

db: check for None instead of boolean false if that is what we mean

If matters a lot whether we find all comments for the specified empty list of
changesets or for None meaning the whole repository.

db: to the extent it makes sense to have a one byte size limit, make it 255 instead of 256 (Issue #96)

Works around some index size issues on MySQL -
http://mechanics.flite.com/blog/2014/07/29/using-innodb-large-prefix-to-avoid-error-1071/ .

hg: adapt for changes in 3.2 and 3.3

Mercurial 3.2:

- moved localrepo.pull to exchange.pull
- removed __getitem__ from lazysets

feed: urlify and escape the commit description

This prevents HTML injections and also makes URLs clickable.

repos: fix redirect after repo creation (and user/group add focus) (Issue #98)

ec39e73be935 introduced a regression in the cases where templates contained
(javascript) snippets outside defined areas. Before, they were included anyway.
After, they were not.

Fixing by moving the chunks I could find inside the main def.

diff: handle GIT delta binary patches

It seems like they only occur rarely; recent git versions do apparently not create them.

Using a test case from https://secure.phabricator.com/T6157 .

spelling: consistent capitalization of URL

Change Url / url into URL.
Additionally, convert the sole use of 'Uri' to URL.

remotes: add support to clone from Mercurial repositories over ssh

This commit adds support to clone a remote Mercurial repository over ssh.

Interactive password authentication is not implemented, nor is support for
pbulic key authentication with passphrases; the repository should be
accessible using bare ssh key authentication.
For this reason, the ssh options -oBatchMode=yes and -oIdentitiesOnly=yes
are added to the ui.ssh setting of Mercurial.

comment handling: extend next/previous links to global comments (issue #91)

Until now, only inline comments were linked to each other with next/previous
links.

This commit extends this mechanism to global comments, such that the last
inline comment has a next link to the first global comment, which has a next
link to the next global comment (and the other way around for previous
links).

In order to work well, instead of hiding inline comments that have been
moved, they actually have to be deleted.

comment handling: clarify shown comment count (inline vs general)

Instead of showing the number of comments as:
y comments (z inline)
show it as:
x comments (z inline, y general)

comment handling: factorize comment count logic

Avoid duplicating the logic to show the number of comments in three
templates (pull request, changeset, changeset comment area) by placing it in
a function.

In tests:
- take into account new line wrapping
- remove pointless %s substitution for fixed values

db: drop most lazy joins

Lazy joins will in some cases turn small selects into joins that returns huge
amounts of redundant data - increasingly bad as the repo size increases.

Lazy joins should only be used after careful analysis and with comments
explaining the case.

This change will make some operations faster and probably also make some
operations slower. Performance regressions would have to be analyzed and
addressed separately ... and differently.

docs: update Windows installation documentation for Windows 7/Server 2008 R2 and newer

Update to the Windows installation documentation following my setup experience
on our production server.

Changes :

* Use of Microsoft Visual C++ Compiler for Python 2.7 which simplifies matter
versus installing Visual Studio 2008 Express, because it removes the need
to use the Visual Studio 2008 command prompt. It is also a lot smaller to
download and install. Unfortunately, this means the instruction will only
work on the same platforms as those which are supported by the compiler.
* For that reason, I split the documentation into newer and older Windows.
* Added more explanations where I feel it was necessary based on my experience
* Added explanation on Git (Warning : I did not try this part)
* Instructions assumes x64 instead of Win32.
* Clarified titles
* Grammar

Potential issues:

* I have the user install pip system wide so that virtualenv installation is
easier (especially if using Python 2.7.9 which already includes pip). One
may prefer to install virtualenv and the pip in the virtual environment (I
know of no good reason, but it could happen).
* Removed some line feeds that I found useless. I do not know the .rst
format, they might be needed. It makes no difference when the documentation
is generated using make.bat, so I am not sure

Potential improvements:

* Instructions on using srvany.exe to install as a Windows service
* Instructions to make a reverse proxy using Apache
* Instructions to make a reverse proxy using IIS

pullrequests: when creating a PR for a specific revision, look for updates on the branch name

TODO: consider bookmarks?

notification: handle unicode translations (Issue #95)

Would fail with localization after 8e1491a7e3af.

[security fix] api: don't send internal data unless asked for it

This changeset fixes CVE-2015-0260.
See <https://kallithea-scm.org/security/cve-2015-0260.html>; for
more details.

error: don't crash on /error/document urls

244c9b103cff was insufficient.

The non-crashing page is however not so relevant ...

icons: fix typo of icon-remove to icon-minus and remove style color

This patch helps unify some of the visual style at a very basic level. We will
punt on doing a more in-depth edit of the visual style until later.

users: use gravatar method from helpers instead of user_gravatar

Now that we have a gravatar method that returns an element instead of an url,
we can use that directly.

gravatar: use font awesome icons

This changes gravatar_url to return an empty string (meaning use an icon)
instead of returning a default image. Since this was a structural change, the
changeset is fairly large.

spelling: fix various typos

This commit fixes various typos or basic English grammar mistakes found by
reviewing the kallithea.pot file.

Full correction of sentences that are not very well formulated, like missing
articles, is out of scope for this commit. Likewise for inconsistent
capitalization of strings like 'Repository group'/'Repository Group'.

pullrequests: make top pane one big form with one save button

This will temporarily break the PR update functionality.

pullrequests: use '-- ' as separator before auto text and put latest revisions at top

The update history in pull request descriptions had a confusing ordering.

Instead, use '-- ' as separator between the description and the history so we
can insert new update info in the right place.

pullrequests: use separate panes for meta data and for the PR repo content - more like when creating the PR

This will make it more clear that the top pane soon will be one form.

pullrequests: reverse the 'available' list - most recent first

Avoid reversing in the templates.

cs_revs should be reversed too. That is for another day.

git: preserve line endings when calling out to git

\r line endings were replaced with \n, and some diffs would thus fail to parse.
That would be the cases similar to what was addressed in fbb992c719aa.

The leading text would be ignored anyway in diffs.py so there is no need to
strip it here. The stripping do also not seem very reliable. But for now we
will keep it.

git: fix version detection with unexpected version string (Issue #71)

Handle version strings like 'git version 1.9.3 (Apple Git-50)'.