changelog: encode branch names with

ref: https://secure.rhodecode.org/rhodecode-fork-kiilerix/changeset/e175420889dc0d2f530bde8e094cc314e129d1a6

locking API returns objects instead of string messages.

- it's now possible to easily parse the output of lock functions

fixed broken API tests after excluding default user
from users listing

fix broken handling of adding an htsts.
Modifing response/request was having trouble in some redirect cases

make user listing have edit button to be consistent
with other admin views

hide listing of default user

- there's no option to edit this user, so listing doesn't make sense
- listing and showing builtin default user is confusing

synced vcs with upstream

- moved subprocessio module to VCS
- many small changes to make embedded vcs as similar to to external lib
- use only absolute imports
- patch vcs config during load pylons env

fix broken handling of adding an htsts.
Modifing response/request was having trouble in some redirect cases

managing users groups enforce permissions checks.
User needs at least a read permissions on usergroup to be able
to assign it somewhere.

UserGroup on UserGroup permissions implementation.
- user group can have another usergroup assigned
- it's impossible to assign usergroup on the same usergroup

Added separate default permission for external_auth account
activation. This flag allows users to define separate option of how
activation of external_accounts should be performed.

create a list out of generator.
Generator gets exausted during later executions, and because it's used several times
it causes errors

emailing: log failing emailing as an error

TODO: The failure should be reported back to the user (or the admins). The
system should not silently not send any emails to the targeted recipients.

Even better: it should inform the user whenever emails was (scheduled to be)
sent - and to whom.

html: move "Submit a bug" to make it more clear that it is for RhodeCode, not the repo

RhodeCode _could_ contain a bug tracker and this link _could_ be for filing
bugs for the hosted projects.

Moving the link to the RhodeCode info makes it more clear that it is for
RhodeCode bugs.

The server instance is however something local, not directly related to the
upstream.

added initial_repo_scan flag for controll if repo scaning should be performed on every startup.
There's always paster repo-scan or repo scann triggered from admin pannel

Unified the paginators for pylons and YUI.
- YUI based paginators now behave more like the ones generated with pylons
- introduced new custom pylons paginator for customizations needed to unify both

invalidation: don't create CacheInvalidation records on startup

Creating the records early gave an advantage before lightweight was introduced.
With lightweight it is no longer necessary.

The records will be created on demand anyway and there is no reason to create and
maintain them before they are used.

invalidation: merge .invalidate and .set_valid as .test_and_set_valid

This simplifies the internal API and avoids leaking CacheInvalidation instances
and cache keys.

removed assertion about ancestor revision.
log this as a warning, and let it proceed.
ref #829

Removed shortlog aka lightweight changelog.
Current version of changelog is fast and condensed.
There's no sense to keep changelog duplicity.

Use changelog controller for displaying history of files.
step 1 for removing obsolete shortlog

api: don't report invalidated cache_keys after invalidating a repo

The keys are an implementation detail and is never relevant outside RhodeCode
internals and should not be leaked.

compare: move get_changesets to compare controller where it is used - 2nd half that was lost in 6c79bfcd3b54

That is a better location than the pull request model. It should probably be
split up and moved to the backend specific Repository classes.

moved around some code in changeset controllers to properly log which function was decorated.
Before it was always index, and permission were checked twice giving unnneded overhead

auth decorators are not used anymore on __before__
- this will allow to create a whitelist of API enabled controller functions
- moved around functions with _ to beginning of the files to make it cleaner

changelog pagination with branch filtering now uses
common logic that non branch filtered version.
- introduced CollectionGenerator object as a helper for
achieving abstraction layer on top of filtered results

get_changeset uses now mercurial revrange to filter out branches.
it's around 20% faster this way

pullrequests: fix reversed diff

b2575bdb847c missed the 'we swap org/other ref' part.

implemented usergroup permissions checks.
- each user who has now explicit or inherited permissions can create usersgrous
- user is automatically an admin of that usergroup, and can manage it

Iteration on default permissions
- added user groups default
- organized global permission form, and made it common for
users, and user groups
- form improvements and intructions

fixed default permissions population during upgrades
- it often happen that introducing new permission
caused default permission to reset it's state to installation
default.
new version makes sure that only missing permissions are
created while leaving old defaults

#818: Bookmarks Do Not Display on Changeset View
- made the consistent order of displaying tags iconss

#818: Bookmarks Do Not Display on Changeset View
- made the consistent order of displaying tags iconss

pullrequests: optimize locating changeset to compare

We only need the max revision - that is much faster when a branch is specified.

pullrequests: use hashes instead of changecontexts

The changecontexts was converted to hex strings when stringified, but better be
explicit.

pullrequests: handle the case where no matching revisions are found for either end

Use -1 as default revision - that is the null revision.

pullrequests: simplify handling of null revisions

Undo unnecessary and incorrect code introduced in bd5420ea396b.

compare: move get_changesets to compare controller where it is used

That is a better location than the pull request model. It should probably be
split up and moved to the backend specific Repository classes.

pullrequests: fix changesets ordering being reversed when creating new pull requests

41b4edf77b5b tried to make the displayed order of changeset consistent: The
topmost is always the latest.

That did however also reverse the ordering of the changesets sent back in the
post when used in the pull request creation form. Displaying the pull request
later on would reverse it again and thus show it in the 'wrong' order.

We now undo that reversing when creating the pull requests, and the stored data
will thus be the same as before.

diffs: drop diffs.differ

This function did not really add any value, it was yet another layer that was
hiding the bug that we use ref[1] without ref[0], and it had this strange
undefined behaviour for diffing across repos.

Inlining the call to .get_diff do not make the code more complex but makes it
more obvious what is going on so it can be cleaned up later.

consistent handling of grant/revoke of permissions widgets
- use 1 method for users and for users groups
- use common JS for ajax revoke
- cleanup code

- Manage User’s Groups: create, delete, rename, add/remove users inside.
by user group admin.
In this case, a user's group can be owned by several people thru an owner user's group.

Some refactoring of naming, permission handling logic.
- remove some code duplicity as well as inconsistent naming