middleware: drop gzipper middleware

It added unfortunate buffering, was only enabled for static_files=true, and
isn't available for TurboGears2.

If necessary, it is better to configure the web server to provide it.

settings: fix saving of visual settings of page size

After 19f15cde2cdb it was no longer to save page_size because formfill didn't
match. Back out a part of that changeset.

middleware: replace references to Errormator with AppEnlight.

Errormator has been rebranded as AppEnlight a while back.

Errormator is no longer available. This is just a trivial rename that can't
make things worse.

style: fix pull request styling

My recent changes broke it. Add some band aid to help it. The pull request page
might not be a perfect fit for Bootstrap forms, but that is a better
approximation than nothing.

tests: give test_pullrequests a test_context in addition to the usual app_fixture

test_pullrequests has unit-ish tests that invoke library functions directly ...
but these happen to require localization initialized. For TG2 we only have
localization initialized when we have a test_context. Thus, additionally wrap
these tests in a test_context.

tests: avoid test_pullrequests keeping dead sqlalchemy repository instance around outside transaction

The previous behaviour happened to work but is fragile when things change -
such as migrating to TG2.

validators: remove unneeded M/StateObj classes

The M class is actually a wrapper around formencode.api.Validator.message,
inserting a translator into the 'state' object. Setting a translator into
the state object is indeed what is mentioned in the formencode docs.

But, if you work this way, the custom state should be set both for custom
validators, as well as for validators that are simple wrappers around
formencode's default validators (for example wrappers that just set a custom
message string). And the latter is what Kallithea is currently _not_ doing.

Also, when using formencode.api.Validator.message correctly, you should not
use the translator function _ on your validator strings manually.

Remove the inconsistency in Kallithea validators as follows:
- remove M and StateObj classes
- replace the usage of M by direct calls to self.message (which is now no
longer in charge of translating but simply of mapping a keyword onto the
right message)
- translation will be done by explicit _ calls at Kallithea side, so that
formencode directly receives translated strings.

forms: wrap LoginForm inside function like other forms

All forms except LoginForm are wrapped inside a function. The original
purpose of this wrapping seems to be the ability to pass parameters to tweak
the form.

But, this also has another desired effect: translation of strings
wrapped with _ is no longer attempted when reading the class definition, but
only when the function is instantiated. In the former case, it is not
guaranteed that a translator is actually available because we are not
running in standard application context.

Align LoginForm with the others.

style: tweak markup for API key admin

The labels were odd - this gives a better starting point for a good Bootstrap UI.

TODO after Bootstrap: Don't use a label as header for the "Add" section.

style: consistently use label markup wrapping around input elements

The 'for="..."' markup is error prone.

style: add missing 'form-control' markup

Based on work by Dominik Ruf.

style: introduce Bootstrap compatible form-inline markup

Based on work by Dominik Ruf.

style: drop 'textarea' class inside 'form-group'

Temporarily, just apply styling to div inside form-group. Also, 'radios' is gone.

Based on work by Dominik Ruf.

style: drop 'select' class inside 'form-group'

Temporarily, just apply styling to div inside form-group. Also, 'radios' is gone.

Based on work by Dominik Ruf.

style: drop 'checkboxes' class inside 'form-group'

Temporarily, just apply styling to div inside form-group. Also, 'radios' is gone.

Based on work by Dominik Ruf.

style: drop 'input' class inside 'form-group'

As long as we use the old styling, just apply styling to div inside form-group.

Based on work by Dominik Ruf.

style: introduce radio-inline / checkbox-inline for status votes - preparing for Bootstrap but so far not used

Based on work by Dominik Ruf.

style: introduce well markup - preparing for Bootstrap but so far not used

Based on work by Dominik Ruf.

style: drop dead 'field' class references

The last references to the class does not match anything essential, and all
css styles can thus also be removed.

Based on work by Dominik Ruf.

style: temporary style tweaks before Bootstrap

Some input fields were truncated - especially if 100% width.

style: drop unused 'focus' class - controls should be 'form-control' instead

Based on work by Dominik Ruf.

templates: use Bootstrap compatible 'form-control' name instead of 'medium' & co

In Bootstrap, form controls tend to be 100%.

tests: use test_context for tests needing internationalization

Instead of relying on the top-level handling of the translator, use the
newly introduced test_context.

tests: introduce test_context to handle internationalization

As preparation to the migration to Turbogears2, introduce a test_context
context manager to wrap certain tests. The context manager provides a
translator for tests that need it. This translator was previously provided
globally to all tests via the TestController.

When swapping Pylons with Turbogears2, the new file
kallithea/tests/test_context.py can be removed, and the test_context from
tg2/tg/util/webtest.py should be used.

tests: remove unused code from conftest.py

conftest.py does not contain an import of pylons (only of pylons.test) so
usage of e.g. pylons.config can never work, so it cannot be used.
Since the tests run fine regardless, we can get rid of this code.

docs: remove some references to Pylons

These references are either not used, or do not provide value.
The Windows installation and email pages still references documents from the
Pylons website -- alternative pages from Turbogears2 need to be found.

error: remove unused Pylons-specific img/style methods

The img and style methods in the error controller are standard Pylons
boilerplate. They are used from the Pylons default error document template.
The purpose of these methods is to serve images and stylesheets from the
Pylons module, rather than having to copy these files into a particular
application installation.

Since Kallithea uses a custom error template with our own styles and images,
these methods are not actually used.

docs: update links to Mercurial's website and wiki

Also Mercurial itself is not a coding standard, so add possessive suffix.

pullrequests: fix 'upgrade' from revision to branch when creating PR

This will do that the default title for the PR created from a non-head revision
will contain a short hash instead a long.

org_ref_type was set to 'branch' while org_ref_name remained the full hash.
h.short_ref would thus not truncate. Instead, we keep the org_ref_type as 'rev'
while storing the branch name in the database.

auth: prevent LDAP query language injection of usernames

This could cause odd LDAP queries that could fail but couldn't give access
without a valid user query and credentials. It thus had no security
implications.

auth: make ldap OPT_X_TLS_CACERTDIR configurable

A location was hardcoded. The location was wrong for many systems and prevented
actual TLS from working. Also, it should not be necessary with modern Pythons.

For some reason, instead of removing it, we now decide to expose it to the
user. Choice FTW!

repo_group: more flexible handling of trailing '/' in repository group names

Don't fail on /_admin/repo_groups/REPO_GROUP_NAME/ .

repo_groups: set c.active when displaying repo creation form errors through repo_group_edit.html

Writing failing tests revealed a crash.

utils: fix broken URL in jsonify warning

Also add a note summarizing the linked concerns.

tests: fix incorrect API key tests

These parameterized tests were supposed to (among other things) test
what happens when the "api_key" query string parameter is not present.
Instead, they literally tested "api_key=None".

auth: remove KallitheaCrypto pseudo-class

Every caller except one already used the module-level wrapper functions.

pullrequests: refactor PullRequestModel().create

The database lookups of the user and repositories are moved outside,
into the callers, which have already looked up the relevant objects,
thus saving two database lookups when creating a PR.

db: it should be "PullRequestReviewer" (singular)

sed -i 's/\bPullRequestReviewers\b/PullRequestReviewer/g' $(hg files)

Just as it's "User", "PullRequest", etc. It's not a collection.

db: rename Gist.gist_owner to Gist.owner_id

For consistency with the existing "owner" relationship.

db: rename ChangesetStatus.changeset_comment_id to comment_id

This ensures consistency with the existing "comment" relationship, as
well as the foreign key (ChangesetComment.comment_id).

db: rename UserFollowing.follows_repo_id to follows_repository_id

Since the relationship is 'follows_repository', rename the column to be
'follows_repository_id', not 'follows_repo_id'. This also makes the
Python column name match the actual database column name.

(The inconsistency dates back to early RhodeCode days.)

db: rename RepoGroup.group_parent_id to parent_group_id

Also for consistency with the existing parent_group relationship.

db: clean up SQLAlchemy session flushes

Many calls to Session().flush() were completely superfluous and have
been removed. (See also the note on "flush" in the contributor docs.)
For the remaining calls, a comment has been added to explain why it's
necessary.

docs: separate coding/contribution guidelines

Try to separate "process" guidelines from "content" guidelines.
(Just moving stuff around here, not changing the actual guidelines.)

login: clarify "Remember be" checkbox - it controls if session should expire with browser session or at timeout

Hint that it is related to cookie expires attribute.

style: put all datatable widgets on one line above the table

This makes tables look less messy - especially on the repogroups page where
there are 2 datatables.

We put all the info above the template so it is visible and stays in the same
place, no matter how many entries are shown or if filtering change the number.

TODO: We should probably get a wrapper around datatable instead of repeating
this so many times ...

templates: fix dropdown functionality of current menu item

After 3e46e6b6a27a, the 'current' menu would have two class attributes and it
would not work as a dropdown. For example, it was not possible to navigate from
Admin>Users to Admin>User Groups.

Instead, get rid of the is_current "helper" and just handle classes explicitly.
That might be slightly more verbose but is also more explicit ... and it works.

style: use Bootstrap compatible markup for alert

Based on work by Dominik Ruf.

style: use span for notifications

Based on Bootstrap work by Dominik Ruf.

style: use span for reviewers instead of div

Based on Bootstrap work by Dominik Ruf.

style: use Bootstrap compatible "text-muted" class

Based on work by Dominik Ruf.

style: introduce "clearfix" class where the Bootstrap migration will need it

Based on work by Dominik Ruf.

style: use Bootstrap compatible data-toggle="tooltip" markup

Based on work by Dominik Ruf and Andrew Shadura.

templates: use bootstrap pagination

The origiinal patch has been modified by Mads Kiilerich.

template: remove obsolete filter textbox and user_group_count

I used grep to find any reference to user_group_count but found none. So there
seems to be no code that actually sets this count. So I removed it.
And since the table is a datatable the filter is redundant anyway.

style: fix structure of my account profile

The avatar was outside the usual wrapping structure.

style: quite-but-not-entirely trivial cleanup of the "search" UI

Providing a cleaner baseline for Bootstrap.

style: quite-but-not-entirely trivial cleanup of "settings, visual"

Providing a cleaner baseline for Bootstrap.

style: replace some disabled btn with Bootstrap compatible label markup

Based on work by Dominik Ruf.

style: refactor form label styling to prepare for Bootstrap and get rid of wrapping with 'label' class

Based on work by Dominik Ruf.

style: put all admin form buttons in a form-group, as our future Bootstrap likes it

Based on work by Dominik Ruf.

style: replace action_button with Bootstrap compatible btn class names

Based on work by Dominik Ruf.

style: use span for tag/bookmark tags ... and make it inline-block to avoid wrapping

Based on work by Dominik Ruf.

style: use Bootstrap compatible btn-danger instead of red ... and similar for other button types

Based on work by Dominik Ruf.

style: adjust button sizes to be more like Bootstrap and change some btn-sm to btn-xs

Based on work by Dominik Ruf.

style: don't use div.action_button for PR reviewers

This is an odd button. The remaining action buttons are more regular.

Based on work by Dominik Ruf.