tests: even smaller setup method refactor for readability

2ffd56e missed u3.

tests: drop setting EMAIL environment variable before git commit - it doesn't work on Windows and seems unnecessary

To minimize the risk, we still remove it from the environment used for running the commands.

tests: set LANG and LANGUAGE - vcs tests expect messages to be in english

Some systems work fine without - especially Windows seems to need it.

hooks: if available, use sys.executable as executable for git hooks

Windows doesn't necessarily have "python2" available in $PATH, but we still
want to make sure we don't end up invoking a python3. Using the absolute path
seems more safe.

notifications: improve response time when number of notifications is large

NotificationsController always retrieved materialized list of all notifications
in database, even to display only 10 of them. This is improved by feeding
SQLAlchemy Query object directly to webhelpers.paginate.Page, avoiding eager
load of all notifications.

js: update select2 to 3.5.4

(4.x seems like a more major upgrade - we stick to the 3 series for now.)

Note that select2-bootstrap.css *not* is upgraded. It is a separate thing (see
LICENSE.md) and currently unused. (Select2 now has similar functionality built
in - that should perhaps be used with Bootstrap instead.)

docs: move translation to a separate page

Start new tradition of putting it under docs/dev/

docs: make the default method for running tests more visible

Sometimes, users found the convoluted and risky method of testing without
recreating the database before spotting the simple method.

repo: better handling of situation where there is no repo to remove

Change internal method _delete_filesystem_repo. We should never end up in such
situations, but this helps debugging if it should happen.

pull-requests: fix missing YUD reference in PR creation

Missed this one in 81a1eb6cd56e ...

docs: restructure Kallithea upgrade instructions

This creates a separate "Upgrading Kallithea" section, instead of trying
(and failing) to repeat the same information for each installation page.
Trying to maintain upgrade instructions for each installation method was
perhaps overly ambitious. In practice, only the Linux instructions were
up-to-date.

(Incidentally, this is kind of a throwback to Kallithea 0.1, which also
had a separate upgrade section.)

templates: use a better class name for an enabled toggle button

"btn-success" is rather a poor choice for a class applied when the
button is active, "active" is better for that.
A side effect of the change is that "Enabled" is now shown in bold.

tests: fix issue with set_test_settings fixture not committing changes

Flushing session is not enough to make setting changes visible in controller
tests.

style: use some ARIA accessibility markup

Use markup from Web Accessibility Initiative - it is default in Bootstrap
examples and "comes for free" but is currently not used, complete, or tested.

See https://en.wikipedia.org/wiki/WAI-ARIA and
https://www.w3.org/WAI/GL/wiki/Using_ARIA_menus .

style: make markup more Bootstrap-compatible

Use Bootstrap classes for dropdowns.
Use explicit Bootstrap-style carets instead of :after preudoclass.
Use Bootstrap class for badges.
Introduce Bootstrap data-toggle properties - currently unused.

api: fix forking of repos in repo groups (Issue #210)

Patch by Alexandre Beaulieu.

api: avoid duplicating group name when updating repo (Issue #37)

The api incorrectly passed repo.repo_name as repo_name, and the model update
function incorrectly always required repo_name.

js: drop some unused parts of YUI

YUI is now only used for autocompletion and statistics.

datatables: put filters in top left corner where they are easier to spot

This could probably also be done with DataTables "dom" positioning strings.

datatables: show 100 entries by default

The jQuery DataTables default of 10 is too few ... and 100 is better than the
old YUI default of 25.

datatables: use jQuery DataTables instead of base.js YUI_datatable wrapper of YAHOO.widget.DataTable

Sorting and searching fixes by Mads Kiilerich.

setup: upgrade SQLAlchemy to 1.0.x series

Tested and reviewed with 1.0.13.

journal: remove right column on journal page - my & watched repos are already available under "my"

This also gets rid of some usage of YUI datatables.

cleanup: remove dead code and templates related to 'Switch To'

a33448d81f70 introduced a new 'Switch To' functionality and removed the last
reference to branch_tag_switcher and thus to switch_to_list.html and the tags,
bookmarks and branches pages.

We don't need these pages ... and if we do, we will implement them differently.
They are mostly YUI datatables with compare links that only can compare within
the same kind of revision names.

helpers: remove <code> from render_w_mentions

b97ba9b23796 introduced use of <code>, but that is semantically incorrect.

The mail templates do not have css and we thus put explicit styling around its
use.

pullrequests: use css for description instead of <code> and explicit styling

b60e58094fb7 introduced use of <code>, but that is semantically incorrect.

tests: remove reference to removed kallithea/tests/parameterized.py

The file was removed in 66c40720e7b2. I guess tests still passed because it
still found the .pyc file.

pytest migration: rename TestControllerPytest back to TestController

The name TestControllerPytest was introduced to allow a temporary situation
where nose/unittest and pytest-based tests could coexist.
This situation is now over, so the base test class can be renamed again.

pytest migration: move init_stack under TestControllerPytest

Avoid top-level methods if they could be placed under classes.
The init_stack method is only used from TestControllerPytest so it makes
sense to scope it under that class.

pytest migration: backout declassification of remove_all_notifications

In order to accomodate both nose/unittest and pytest at the same time,
method remove_all_notifications has been extracted from BaseTestCase in
commit 37d713674f63.
Now that nose/unittest is no longer used, we can backout this change again.

pytest migration: merge TestControllerPytest with BaseTestController

There is no need anymore for a separate BaseTestController class.
Simplify the code by removing it.

pytest migration: remove custom 'parameterized' implementation

Since all tests have been converted to pure pytest style, we can get rid of
the custom 'parameterized' helper, and use pytest's parametrize instead.

pytest migration: remove original TestController and BaseTestCase

Since all tests have been migrated to TestControllerPytest, we can remove
these classes.

pytest migration: __init__: switch to standard assert statements

Use unittest2pytest to replace unittest-style assert statements (e.g.
assertEqual) with standard Python assert statements to benefit from pytest's
improved reporting on assert failures.

The conversion by unittest2pytest was correct.

pytest migration: functional: switch to standard assert statements

Use unittest2pytest to replace unittest-style assert statements (e.g.
assertEqual) with standard Python assert statements to benefit from pytest's
improved reporting on assert failures.

The conversion by unittest2pytest was correct, except for line wrapping
problems.

pytest migration: api: switch to standard assert statements

Use unittest2pytest to replace unittest-style assert statements (e.g.
assertEqual) with standard Python assert statements to benefit from pytest's
improved reporting on assert failures.

The conversion by unittest2pytest was correct.

pytest migration: models: switch to standard assert statements

Use unittest2pytest to replace unittest-style assert statements (e.g.
assertEqual) with standard Python assert statements to benefit from pytest's
improved reporting on assert failures.

The conversion by unittest2pytest was correct except for:
- 'import pytest' is not automatically added when needed
- line wrapping in string formatting caused a syntax error in the
transformed code. Reported upstream at
https://github.com/pytest-dev/unittest2pytest/issues/3 .
- in assertRaises with a lambda, the lambda needs to be removed

pytest migration: other: switch to standard assert statements

Use unittest2pytest to replace unittest-style assert statements (e.g.
assertEqual) with standard Python assert statements to benefit from pytest's
improved reporting on assert failures.

The conversion by unittest2pytest was correct except for:
- 'import pytest' is not automatically added when needed
- line wrapping in string formatting caused a syntax error in the
transformed code. Reported upstream at
https://github.com/pytest-dev/unittest2pytest/issues/3 .

pytest migration: add args/kwargs to assertRaises replacement

Even though we'll soon get rid of the assertRaises replacement, the tests in
kallithea/tests/other/test_validators.py expect to pass it args and kwargs
so we need to adapt it first.

tests: users: enable commented UsersController test

Previously, a test was written but could not be enabled until pytest
was fully available. Now that it's the case, enable the test.

tests: api: fix intertest dependency on repository locking

In test classes based on unittest, tests are executed in alphabetical order.
In test classes based on pytest, tests are executed in the order they are
specified. This difference revealed a problem in the API tests:

- test_api_lock_repo_lock_optional_locked locks the test repository
- test_api_get_locks_regular_user gets the current locks and expects it to
be empty

With unittest as base class, this worked fine because the 'get_locks' group
of tests are executed before the 'lock_repo' group (alphabetical order).
Using a real pytest-based test class, the order is swapped and the locked
repository from the first test invalidates the preconditions of the second
test.

Fix this specific problem by releasing the lock from
test_api_lock_repo_lock_optional_locked.

This commit does not fix other interdependencies between tests. For example,
test_api_lock_repo_lock_optional_locked expects the existing lock state to
be 'locked' but did not lock the repo itself; instead it expects a previous
test to have locked. In practice, this is
test_api_lock_repo_lock_aquire_optional_userid.
A full solution would make each test fully self contained so that tests can
be executed in random order. The pytest extension pytest-random can help
detecting these problems.

tests: add set_test_settings fixture

Uses https://pytest.org/latest/yieldfixture.html#yieldfixture to restore
settings after tests. Takes into account current specifics of list-valued
settings.

tests: add create_test_user fixture

Uses https://pytest.org/latest/yieldfixture.html#yieldfixture to provide
auto-deleting users to tests.

subprocess: output on stderr doesn't mean that a process failed

Git sometimes does that. Threading non-determinism did that we sometimes didn't
see it, and sometimes we failed.

templates: be more strict about mako errors

We prefer to find errors early.

pullrequests: reword the grumpy "Rejected" to the more neutral and factual "Not approved"

"Rejecting" could be considered rude and some reviewers were thus reluctant to
use it. Rewording it might give reviewers a voice to better express their
feelings.

docs: tweak email documentation - add gmail example

smtp_auth is too obscure to have in the .ini template.

pull requests: refactor update_reviewers

This avoids a redundant database lookup for every removed reviewer,
and shows usernames (not just IDs) in associated log messages.

pull requests: prevent adding DEFAULT user as reviewer

Add a helper method to resolve reviewers, with an added check to prevent
the adding of the DEFAULT user as reviewer.

The __add_reviewers method, although internal, had a troubling interface
where the method was responsible for resolving reviewers, but the caller
was responsible for resolving mention_recipients. The method is changed
to always take two sets of database User objects, leaving the resolution
to the caller in both cases.