pullrequests: when creating a PR for a specific revision, look for updates on the branch name

TODO: consider bookmarks?

notification: handle unicode translations (Issue #95)

Would fail with localization after 8e1491a7e3af.

[security fix] api: don't send internal data unless asked for it

This changeset fixes CVE-2015-0260.
See <https://kallithea-scm.org/security/cve-2015-0260.html>; for
more details.

error: don't crash on /error/document urls

244c9b103cff was insufficient.

The non-crashing page is however not so relevant ...

icons: fix typo of icon-remove to icon-minus and remove style color

This patch helps unify some of the visual style at a very basic level. We will
punt on doing a more in-depth edit of the visual style until later.

users: use gravatar method from helpers instead of user_gravatar

Now that we have a gravatar method that returns an element instead of an url,
we can use that directly.

gravatar: use font awesome icons

This changes gravatar_url to return an empty string (meaning use an icon)
instead of returning a default image. Since this was a structural change, the
changeset is fairly large.

spelling: fix various typos

This commit fixes various typos or basic English grammar mistakes found by
reviewing the kallithea.pot file.

Full correction of sentences that are not very well formulated, like missing
articles, is out of scope for this commit. Likewise for inconsistent
capitalization of strings like 'Repository group'/'Repository Group'.

pullrequests: make top pane one big form with one save button

This will temporarily break the PR update functionality.

pullrequests: use '-- ' as separator before auto text and put latest revisions at top

The update history in pull request descriptions had a confusing ordering.

Instead, use '-- ' as separator between the description and the history so we
can insert new update info in the right place.

pullrequests: use separate panes for meta data and for the PR repo content - more like when creating the PR

This will make it more clear that the top pane soon will be one form.

pullrequests: reverse the 'available' list - most recent first

Avoid reversing in the templates.

cs_revs should be reversed too. That is for another day.

git: preserve line endings when calling out to git

\r line endings were replaced with \n, and some diffs would thus fail to parse.
That would be the cases similar to what was addressed in fbb992c719aa.

The leading text would be ignored anyway in diffs.py so there is no need to
strip it here. The stripping do also not seem very reliable. But for now we
will keep it.

git: fix version detection with unexpected version string (Issue #71)

Handle version strings like 'git version 1.9.3 (Apple Git-50)'.

Translated using Weblate (German)

Currently translated at 31.4% (339 of 1077 strings)

Translated using Weblate (French)

Currently translated at 73.0% (787 of 1077 strings)

Translated using Weblate (French)

Currently translated at 72.9% (786 of 1077 strings)

Translated using Weblate (French)

Currently translated at 56.7% (611 of 1077 strings)

Translated using Weblate (Simplified Chinese)

Currently translated at 45.9% (495 of 1077 strings)

Translated using Weblate (Russian)

Currently translated at 78.9% (850 of 1077 strings)

Translated using Weblate (Polish)

Currently translated at 79.1% (852 of 1077 strings)

Translated using Weblate (French)

Currently translated at 44.3% (478 of 1077 strings)

Translated using Weblate (Czech)

Currently translated at 1.7% (19 of 1077 strings)

Translated using Weblate (Hungarian)

Currently translated at 100% (0 of 0 strings)

Created new translation.

Translated using Weblate (Czech)

Currently translated at 1.4% (16 of 1077 strings)

Translated using Weblate (Czech)

Currently translated at 100% (0 of 0 strings)

Created new translation.

user: use h.person(obj.user) instead of h.person(obj.user.username) - don't fail if user is None

h.person prefer a user object anyway - just pass it obj.user and make sure
h.person doesn't crash on getting a None user.

user: prevent deletion of users that are owners of a user group

TODO: make it possible to reassign group ownership

user: prevent deletion of users that are owners of a repo group

TODO: make it possible to reassign group ownership

utils: better display of ages >1 year when in short form

* 1..2 years: display as months instead
* 2+ years: round

error: be prepared for resp without status

I have seen traces that shows that it can happen. Be prepared!

utils: don't use FromCache - it doesn't work properly

It seems like the caching worked fine for caching the list of ui_ids. The
actual records were however not cached so they had to be fetched one by one
anyway. Fetching everything up front is cheaper than fetching one by one.

db: add indices where queries takes more than 100 ms

CREATE INDEX cc_pull_request_id_idx ON changeset_comments USING btree (pull_request_id);
CREATE INDEX cs_changeset_comment_id_idx ON changeset_statuses USING btree (changeset_comment_id);
CREATE INDEX cs_pull_request_id_idx ON changeset_statuses USING btree (pull_request_id);
CREATE INDEX pr_org_repo_id_idx ON pull_requests USING btree (org_repo_id);
CREATE INDEX pr_other_repo_id_idx ON pull_requests USING btree (other_repo_id);

comments: introduce lazy join of ChangesetStatus on ChangesetComment

99% of all uses of ChangesetComment will also need the optional corresponding
ChangesetStatus (if any) on the status_change relationship. Fetching it on
demand gives a lot of roundtrips and might be slow ... but adding explicit bulk
queries everywhere do not seem feasible. Adding lazy=joined in the data model
seems like the best solution.

Loading a pull request with 10 comments on a slow repo goes from 3.5 s to
2.7 s.

comments: optimize notification creation

.append to the sqlalchemy collection is apparently expensive. Setting the
reference the other way around is much faster. Adding a notification for a
single user goes from 0.25 s to 0.001 s.

On a slow repo and a pullrequest with 14 reviewers, adding a comment goes from
8.5 s to 0.8 s.

changeset status: drop default 'unreviewed' status for changesets on PRs

The default is expensive to compute and doesn't scale - especially not with the
current data model where all pull-request revisions are stored in a single
field and not just can be indexed and join in the database.

cleanup: avoid some 'except Exception' catching - catch specific exceptions or log it and show what happened

This has a risk of introducing regressions ... but we want to get rid of all
exception muting and make the whole system less fragile and easier to debug.

helpers: refactor urlify_commit, extract urlify_issues function

A slight improvement of code, but also prepares for other wip changes.

db: just fail badly if a repo can't be loaded (probably missing in file systems)

The error condition could perhaps be reported to the user in a better way, but
propagating the VCS error seems like a better approximation of that than just
logging it and failing silent.

cache invalidation: don't commit session if nothing changed

It seems like a good idea to avoid unnecessary commits, considering we use
expire_on_commit=True.

It would perhaps be even better to postpone the commit to the end of the
session - that is for another day.

pullrequests: drop expensive listing of unrelated changesets that cannot be used for update

It rarely gave any relevant info and could take several seconds to compute.

Instead, just warn if the branch name has another head.

Loading a pullrequest page on a slow repo did in one setup go from 7 s to 3.5 s.

hg: reimplement branch listings more efficiently

Gives a 10 x speedup - which is noticable on big slow repos where the old
implementation took several seconds.

pullrequests: store the 'a' branch name in template context

This is not used upstream yet but is useful for customizations. Getting this
change in early avoids conflicts when developing other changes.

hg: drop support for hg web.hidden

Kallithea is not hgweb and should not try to support hgweb config options.

If someone wants to hide repos, they should just remove all access to them.

(_If_ Kallithea should support some kind of more thorough repo hiding, it
should be implemented differently: The hidden repos should not be in the
database and should thus instead be excluded when scanning for repos.)

styling: don't loop on loading kallithea-logo.png after kallithea-logo.svg failed

Bad configuration of static files or static_files=false could make the page
loop when trying to apply the svg/png fallback.

Instead, let the error handler remove itself when it is used the first time.

error: remove allmost unused code for redirect on error page

It is much better to just stop and show the error message.

json: drop simplejson fallback and just use stdlib

The performance gain from using simplejson is questionable and undocumented for
our use. Keep it simple.