javascript: ypjax cleanup

Set 'Loading ...' while waiting for response.

javascript: ypjax callback is optional and do not have any parameters

In files, read cache value from DOM.

graph: don't draw edges to roots as "dead ends"

Roots and dead ends both don't have outgoing edges. The difference is that
roots will have the dot of the line - dead ends will not.

diff: don't group diffs based on the kind of change

We do no longer show the content of deleted files so there is no longer any
reason to put them at the end. Keeping all changes sorted by file name makes it
easier to review.

pull requests: add url parameters to page link

Previously, closed and from_ parameters not passed to page link.

git: fix "'name' must be bytestring, not unicode" error on browsing changesets

Adding some extra safe_str to address
https://bitbucket.org/conservancy/kallithea/issue/24/clicking-on-changesets-results-in-a-500
seems consistent with existing code.

support other analytic systems then just Google Analytics

Fallback to Google Analytics code if the string starts with "UA-"

diff: consistently use a=base=ancestor and b=changes in compare and PR

Some additional fixes to the previous change.

diff: rename template values for org and other for compare and PR

sed -i -e 's,\<\(c\.\(default_\)\?\)org_,\1a_,g' -e 's,\<\(c\.\(default_\)\?\)other_,\1cs_,g' kallithea/controllers/compare.py kallithea/templates/compare/compare_cs.html kallithea/templates/compare/compare_diff.html
sed -i -e 's,\<\(c\.\(default_\)\?\)org_,\1cs_,g' -e 's,\<\(c\.\(default_\)\?\)other_,\1a_,g' kallithea/controllers/pullrequests.py kallithea/templates/pullrequests/pullrequest.html kallithea/templates/pullrequests/pullrequest_show.html kallithea/templates/changeset/diff_block.html

Renaming it differently for compare and PR finally fixes some issues with diffs
and links pointing at wrong revisions and repos - no more whac-a-mole.

pull requests: load repo branch info on demand after changing repo

Visiting a lot of repositories for no reason takes time.

graph: handle failing canvas creation

Seen randomly when PR had "No changesets" or when reloading while the changelog
+ graph was loading.

pull requests: rework handling of comments and texts when voting and closing

Close did not leave any records - now it does.

Status changes without comments repeated the status change in text - now it
doesn't repeat itself.

https: introduce https_fixup config setting to enable the special https hacks

Without https_fixup, correctly configured WSGI systems work correctly.

The https_fixup middleware will only be loaded when enabled in the configuration.

notifications: fix threading - use line number

TODO: Use a more stable link, something that includes the filename.

urls: introduce canonical_url config setting

All URLs that are shown or persisted or emailed will use this instead of the
current url.

This is convenient when the server has multiple names - for instance when
transitioning from one protocol or domain or hostname to another.

hg: optimize get_ref_revision

Avoid expensive branch(x) iterating over whole repo just to take max.

old style: better display of multiple parents/children in changeset view - don't truncate

This might introduce some rendering artifacts instead of truncating. That will
be addressed when the styling is reworked from scratch.

auth: unauthenticated users do not have full_name_or_username - show login box instead

AuthUser is only fully populated after it has been loaded with db fields ...
but that only happens for authenticated users. Anonymous users could thus
trigger a crash.

pull request: fail on form errors - don't redirect

The error page might not be pretty but it is very usable - the user can go back and fix the problem.

pull requests: wrap long lines in diff instead of truncating them

A horizontal scrollbar would not be a convenient solution.

indexer: rework get_node to handle alternative path element separators

Problem seen on Windows by Dominik Ruf.

pull requests: use formencode.Set for initial reviewer list

This works with formencode 1.2.6 too.

This also makes it possible to have an empty initial reviewer list.